Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #23

Merged
merged 6 commits into from Jul 16, 2019
Merged

Refactoring #23

merged 6 commits into from Jul 16, 2019

Conversation

FlYos
Copy link
Contributor

@FlYos FlYos commented Jul 15, 2019

Small refactoring for improve readability

@Gummibeer
Copy link
Member

Hey,
thanks for your proposal. Could you merge the current master into your branch to make CircleCI work again?
Except of this I don't want to introduce a new public method for this. Because it's only needed for the translation relation I would make it private.

@Gummibeer Gummibeer self-assigned this Jul 15, 2019
@Gummibeer
Copy link
Member

@FlYos thanks for the fast adjustments! :)
Will release it in the next release. I think that it will be this week - just have to check if I can release something else with it.

@Gummibeer Gummibeer merged commit 4025c0f into Astrotomic:master Jul 16, 2019
@Gummibeer
Copy link
Member

https://github.com/Astrotomic/laravel-translatable/releases/tag/v11.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gummibeer Gummibeer Gummibeer approved these changes

Assignees

@Gummibeer Gummibeer

Labels
next release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FlYos @Gummibeer